Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

Also make Tycho build execute that test suite instead of individual tests.

@HeikoKlare HeikoKlare force-pushed the junit5-terminaltests-suite branch from ee3bee2 to 639dd5a Compare January 4, 2026 16:07
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Test Results

 1 974 files  +18   1 974 suites  +18   1h 39m 19s ⏱️ + 4m 2s
 4 743 tests ± 0   4 719 ✅ ± 0   24 💤 ±0  0 ❌ ±0 
14 229 runs  ± 0  14 047 ✅ ± 0  182 💤 ±0  0 ❌ ±0 

Results for commit 97bda6d. ± Comparison against base commit fd94e7c.

This pull request removes 336 and adds 336 tests. Note that renamed tests count towards both.
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testConnect
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testDisconnect
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetAdapter
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetIdAndName
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetInitializationErrorMessage
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetSettingsSummary
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetTerminalToRemoteStream
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testIsInitialized
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testIsLocalEcho
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testLoad
…
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testConnect
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testDisconnect
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testGetAdapter
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testGetIdAndName
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testGetInitializationErrorMessage
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testGetSettingsSummary
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testGetTerminalToRemoteStream
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testIsInitialized
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testIsLocalEcho
AutomatedIntegrationSuite AutomatedPluginTestSuite TerminalConnectorFactoryTest ‑ testLoad
…

♻️ This comment has been updated with latest results.

Also adds missing test class to suites structure and makes Tycho build
execute that test suite instead of individual tests.
@HeikoKlare HeikoKlare force-pushed the junit5-terminaltests-suite branch from 639dd5a to 97bda6d Compare January 4, 2026 16:58
@HeikoKlare
Copy link
Contributor Author

HeikoKlare commented Jan 4, 2026

image

Caused by VT100EmulatorTest missing in the test suites. Added with latest commit.

@akurtakov akurtakov merged commit f5d6a70 into eclipse-platform:master Jan 4, 2026
18 checks passed
@HeikoKlare HeikoKlare deleted the junit5-terminaltests-suite branch January 4, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants