Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Jan 4, 2026

The terminal tests currently lack a test.xml required for their nightly execution in the I-Build tests. This change adds them. A follow up change that integrates the test in the aggregation is required (see eclipse-platform/eclipse.platform.releng.aggregator#3590).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Test Results

 1 977 files  ±0   1 977 suites  ±0   1h 42m 32s ⏱️ + 6m 37s
 4 743 tests ±0   4 719 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 229 runs  ±0  14 047 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit 2568f66. ± Comparison against base commit 49f5918.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member

Thanks for this.

In general I think for simple cases we should provide less verbose means to activate I-build test execution, e.g. by a special custom manifest header or alike.

@HeikoKlare
Copy link
Contributor Author

This PR is not validated by CI as it only adds an Ant configuration. The failing test is unrelated and known to be flaky: #1033

In general I think for simple cases we should provide less verbose means to activate I-build test execution, e.g. by a special custom manifest header or alike.

Yes, that would definitely be good. At best, the I-Build should take the same tests as also taken by GHA builds via Tycho instead of having the additional Ant configurations, but it would be an even longer way to go.

@HeikoKlare HeikoKlare force-pushed the junit5-terminaltests-test.xml branch from 768f471 to 4d0e929 Compare January 5, 2026 09:35
@HeikoKlare HeikoKlare force-pushed the junit5-terminaltests-test.xml branch from 4d0e929 to 2568f66 Compare January 5, 2026 09:36
@HeikoKlare HeikoKlare merged commit a916d03 into eclipse-platform:master Jan 5, 2026
18 checks passed
@HeikoKlare HeikoKlare deleted the junit5-terminaltests-test.xml branch January 5, 2026 11:12
@laeubi
Copy link
Contributor

laeubi commented Jan 5, 2026

e.g. by a special custom manifest header or alike

bndlib uses Test-Cases header for that purpose. I once looked into it but it seems we are requiring this because the test are actually executed by ant and there are some categories like performance tests. I think most of this could these days be replaced by JUnit Tags and a special test discovery strategy anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants