Skip to content

Conversation

@umaucher
Copy link
Contributor

update various bazel modules and usage

umaucher added 3 commits June 12, 2025 10:33
Use the base-branch provided as input for the gitlint call.
Update score_docs_as_code to 0.3.3 and adapted usage in according workflow.
Update rules_python module to 1.4.1
@github-actions
Copy link

github-actions bot commented Jun 12, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ✅ Passed

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 358515ae-6c9a-4b72-9f76-a3c157cb3820
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version googletest@1.14.0, but got googletest@1.14.0.bcr.1 in the resolved dependency graph.
WARNING: For repository 'score_python_basics', the root module requires module version score_python_basics@0.3.0, but got score_python_basics@0.3.2 in the resolved dependency graph.
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.4.2 in the resolved dependency graph.
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (57 packages loaded, 10 targets configured)

Analyzing: target //:license-check (102 packages loaded, 10 targets configured)

Analyzing: target //:license-check (132 packages loaded, 185 targets configured)

Analyzing: target //:license-check (156 packages loaded, 1894 targets configured)

Analyzing: target //:license-check (165 packages loaded, 2650 targets configured)

Analyzing: target //:license-check (165 packages loaded, 2868 targets configured)

Analyzing: target //:license-check (165 packages loaded, 2868 targets configured)

Analyzing: target //:license-check (168 packages loaded, 4874 targets configured)

Analyzing: target //:license-check (169 packages loaded, 4998 targets configured)

Analyzing: target //:license-check (170 packages loaded, 5118 targets configured)

Analyzing: target //:license-check (170 packages loaded, 5118 targets configured)

Analyzing: target //:license-check (170 packages loaded, 5118 targets configured)

INFO: Analyzed target //:license-check (171 packages loaded, 7037 targets configured).
[8 / 13] checking cached actions
[9 / 13] JavaToolchainCompileClasses external/rules_java~/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[11 / 13] JavaToolchainCompileBootClasspath external/rules_java~/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[12 / 13] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 196.810s, Critical Path: 2.66s
INFO: 13 processes: 9 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/module_template -token otyhZ4eaRYK1tKLNNF-Y
[main] INFO Querying Eclipse Foundation for license data for 2 items.
[main] INFO Found 1 items.
[main] INFO Querying ClearlyDefined for license data for 1 items.
[main] INFO Found 1 items.
[main] INFO Vetted license information was found for all content. No further investigation is required.

No need for overwrite defaults to origin/main which is for now the main use
case. Still variable could be used if needed.
@umaucher umaucher marked this pull request as ready for review June 13, 2025 07:14
- -c
- |
git config --global --add safe.directory /github/workspace && \
git fetch origin +refs/heads/main:refs/remotes/origin/main && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to fetch that base branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicu1989 why don't we use something generic like this instead of input variables?

TARGET_BRANCH="${{ github.event.pull_request.base.ref || github.ref_name }}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this action cannot access to the github.* context at execution time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, because it's a docker action.
So as long as the default works we can keep it as is.
But if we need better support of e.g. auto detecting branches, then we should convert this to a composite action?!
(or javascript action if someone is bored)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah composite action should work with github context. my remark was to update the fetch as well since the author changed the gitlint command from default main to input.base-branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this now as the PR is an improvement, even if incomplete

@AlexanderLanin AlexanderLanin merged commit 9109c3b into eclipse-score:main Jun 16, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Infrastructure Jun 16, 2025
@umaucher umaucher deleted the um_tmplupdate branch June 17, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants