impl: enable log and mw_log

[arkjedrz]

• Add more logs from the implementation.
• Fix tests.
• Fix building from Cargo and Bazel.
• Disable score-log feature in CI check.

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: fa774766-06a5-4ff5-aebd-f5f3fc30f054
Computing main repo mapping: 
DEBUG: Rule 'score_logging+' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "bcbd0babce56cdccd955684f7584bc486643ed8f" and dropping ["branch"]
DEBUG: Repository score_logging+ instantiated at:
  <builtin>: in <toplevel>
Repository rule git_repository defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/git.bzl:208:33: in <toplevel>
DEBUG: Rule 'score_baselibs_rust+' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "a65f5cbdf8ded985201bf45242cbff46c92c6dda" and dropping ["branch"]
DEBUG: Repository score_baselibs_rust+ instantiated at:
  <builtin>: in <toplevel>
Repository rule git_repository defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/git.bzl:208:33: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_rust', the root module requires module version rules_rust@0.56.0, but got rules_rust@0.61.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.1.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_docs_as_code', the root module requires module version score_docs_as_code@2.0.1, but got score_docs_as_code@2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'platforms', the root module requires module version platforms@0.0.11, but got platforms@1.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 6 packages loaded
Loading: 6 packages loaded
    currently loading: 
Analyzing: target //:license-check (7 packages loaded, 0 targets configured)
Analyzing: target //:license-check (7 packages loaded, 0 targets configured)

Analyzing: target //:license-check (91 packages loaded, 9 targets configured)

Analyzing: target //:license-check (120 packages loaded, 196 targets configured)

Analyzing: target //:license-check (158 packages loaded, 2822 targets configured)

Analyzing: target //:license-check (164 packages loaded, 6985 targets configured)

Analyzing: target //:license-check (167 packages loaded, 8992 targets configured)

INFO: Analyzed target //:license-check (167 packages loaded, 9001 targets configured).
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 81 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.411s, Critical Path: 0.37s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[github-actions]

The created documentation from the pull request is available at: docu-html

[vbogdanb]

some of the debug messages seem a bit redundant in the case of an error, for example this one you would get :
"Loading KVS file: kvs_path"
"Failed to load KVS file: kvs_path"

[arkjedrz]

In this case yes, to a degree. Imagine following scenarios though:

• Loading succeeded, but parsing failed. Thanks to those logs You have information about steps being done and state of KVS without having to look at the code.
• Something went extremely wrong during fs::read_to_string and app segfaulted. Thanks to that You have last known operation done.

I have the following rule of thumb for log levels:

• trace - extremely granular information what changed (e.g., operation result, function-local state changed). Rarely used.
• debug - information what is being done right now (before it happen).
• info - global-state change.
• warn - non-critical pre- or post- condition failed.
• error - critical pre- or post-condition failed.

[vbogdanb]

Same thing here, the first one it makes the second message redundant