-
Notifications
You must be signed in to change notification settings - Fork 16
Improvement: correct architecture elements and modify component template #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: correct architecture elements and modify component template #462
Conversation
|
The created documentation from the pull request is available at: docu-html |
masc2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is feature not updated too in this PR, as it is also introduced? Should there not be an relationship between static architectures and components?
process/folder_templates/modules/module_name/component_name/docs/architecture/index.rst
Show resolved
Hide resolved
I'm on the relation to the code from the safety audit findings. Feature can be added later (small PRs). |
Disagree her, you introduced already the feature type, see your PR, so why not reflecting it directly, and I see no relationship why you should only consider audit findings as argument against it. |
Added feature now ... |
masc2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the including of the feature. Let's discuss some general topics tomorrow in the meeting
process/folder_templates/modules/module_name/component_name/docs/architecture/index.rst
Show resolved
Hide resolved
process/folder_templates/modules/module_name/component_name/docs/architecture/index.rst
Show resolved
Hide resolved
| :security: YES | ||
| :safety: ASIL_B | ||
| :status: invalid | ||
| :implements: logic_arc_int__feature_name__interface_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be clarified in future, if this is correct
📌 Description
Correct architecture elements and modify component template accordingly
🚨 Impact Analysis
✅ Checklist