Move sphinx build to execution phase #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR shows how a sphinx build can be moved to the execution phase of bazel builds. Addditionally, module documentation is now imported from `sphinx_docs_library` targets of dependent modules. This pr depends on changes in [PR](eclipse-score/docs-as-code#327)
ramceb
force-pushed
the
mb_sphinx_in_execution_phase
branch
from
6c9c91a to
15c2ed7
Compare
6 tasks
a-zw
reviewed
Dec 10, 2025
| source_dir = "docs" | ||
|
|
||
| sphinx_docs( | ||
| name = "html", |
Contributor
There was a problem hiding this comment.
This seems to do essentially the same as bazel run :docs_combo_experimental except that it does not work incrementally but run sphinx-build from scratch all the time. This is good for determinism but slower when used interactively.
I proposed something similar in eclipse-score/docs-as-code#286 but we abandoned it because experience was that supporting multiple ways to build stuff was not reliable enough.
Author
There was a problem hiding this comment.
Looks like a very similar approach. Thanks for the hint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how a sphinx build can be moved to
the execution phase of bazel builds.
Addditionally, module documentation is now
imported from
sphinx_docs_librarytargets ofdependent modules.
This pr depends on changes in
PR