Skip to content

Cross-VM IPC (#916) #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FScholPer wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Cross-VM IPC (#916) #1371

FScholPer wants to merge 26 commits into from

Conversation

@FScholPer
Copy link
Contributor

@FScholPer FScholPer commented Jul 4, 2025

Added Feature Request description and requirements

Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information

@FScholPer FScholPer linked an issue Jul 4, 2025 that may be closed by this pull request
Feature Modification for Cross-VM IPC #916
Open
timkl7
timkl7 suggested changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@timkl7 timkl7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue with directory name

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

The created documentation from the pull request is available at: docu-html

hth9fe
hth9fe reviewed Aug 1, 2025
View reviewed changes
hth9fe
hth9fe reviewed Aug 1, 2025
View reviewed changes
@HartmannNico HartmannNico changed the title docs: added nonipc feature(#916) Cross-VM IPC (#916) Aug 4, 2025
@HartmannNico
Copy link
Contributor

HartmannNico commented Aug 4, 2025

In COM Architecture Meeting on 2025/08/04 we concluded this is a modification of the FR for COM #229. Hence this FR/PR does not constitute a new feature, but creates an updated version of the COM FR.
The description and requiremements from features/nonipc folder shall move into features/ipc.
We use this PR to follow up on this documentation migration appropriately.

hth9fe
hth9fe reviewed Aug 6, 2025
View reviewed changes
Copy link
Contributor

@hth9fe hth9fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

@AlexanderLanin AlexanderLanin requested a review from Copilot August 6, 2025 14:05

This comment was marked as outdated.

Sign in to view

FScholPer and others added 5 commits August 7, 2025 08:21
@FScholPer @hth9fe
Update docs/features/communication/crossvm/index.rst
7436c4d 
Co-authored-by: ThomasHahn <83017581+hth9fe@users.noreply.github.com>
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
@FScholPer @hth9fe
Update docs/features/communication/crossvm/requirements/index.rst
6046bd6 
Co-authored-by: ThomasHahn <83017581+hth9fe@users.noreply.github.com>
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
@FScholPer @hth9fe
Update docs/requirements/stakeholder/index.rst
3bb7e41 
Co-authored-by: ThomasHahn <83017581+hth9fe@users.noreply.github.com>
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
@FScholPer @hth9fe
Update docs/features/communication/crossvm/index.rst
9ab19f3 
Co-authored-by: ThomasHahn <83017581+hth9fe@users.noreply.github.com>
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
@FScholPer @hth9fe
Update docs/features/communication/crossvm/index.rst
a69af69 
Co-authored-by: ThomasHahn <83017581+hth9fe@users.noreply.github.com>
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
@AlexanderLanin AlexanderLanin requested a review from Copilot August 7, 2025 07:14
@FScholPer
Copy link
Contributor Author

FScholPer commented Aug 8, 2025

@LittleHuba As it resides also in com and uses the same prefix it is part of com and so lola. The only difference is that I used another folder as this is another usecase as normal IPC. But it is still a modification request and vm to vm is not the only part as you can read.

@LittleHuba
Copy link
Contributor

LittleHuba commented Aug 11, 2025

Ahh okay now I understand the misunderstanding.
The communication feature is not LoLa. The communication feature corresponds to mw::com.
The IPC subfeature of the communication feature corresponds to LoLa.

The summary from the architecture workshop was, that your request boils down to IPC across VM boundaries.
Hence, the request to directly modify the IPC subfeature and not add another subfeature next to IPC.

@FScholPer
Merge remote-tracking branch 'origin/main' into 916-fq-non-ipc-shared…
cccfcef 
…-memory-com

# Conflicts:
#	docs/features/communication/index.rst
@FScholPer FScholPer force-pushed the 916-fq-non-ipc-shared-memory-com branch from 68e5d40 to 0eba313 Compare September 10, 2025 10:56
@FScholPer
Copy link
Contributor Author

FScholPer commented Sep 15, 2025

@LittleHuba @crimson11 as discussed in the last com meeting this pull request does now only contain the cross vm part. The rest will be now in #1715. Please review

@FScholPer FScholPer mentioned this pull request Sep 16, 2025
Closed
2 tasks
@LittleHuba
Copy link
Contributor

LittleHuba commented Oct 1, 2025

@FScholPer Given that the improvement eclipse-score/process_description#170 is done, could you please add the validity information to the two requirements?

While you are at it, it would also be nice if you could clean up the commit history of the PR. Thanks!

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

@FScholPer
Copy link
Contributor Author

FScholPer commented Oct 21, 2025

@FScholPer Given that the improvement eclipse-score/process_description#170 is done, could you please add the validity information to the two requirements?

While you are at it, it would also be nice if you could clean up the commit history of the PR. Thanks!

done

opajonk
opajonk approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@opajonk opajonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this simply should go in now?

LittleHuba
LittleHuba previously approved these changes Nov 6, 2025
View reviewed changes
opajonk
opajonk reviewed Nov 19, 2025
View reviewed changes
@FScholPer @opajonk
Update docs/requirements/stakeholder/index.rst
59a8deb 
Co-authored-by: Oliver Pajonk <oliver.pajonk@elektrobit.com>
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
@FScholPer
Merge branch 'main' into 916-fq-non-ipc-shared-memory-com
8348873 
Signed-off-by: Frank Scholter Peres(MBTI) <145544737+FScholPer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HartmannNico HartmannNico HartmannNico left review comments

Copilot code review Copilot Copilot left review comments

@AlexanderLanin AlexanderLanin AlexanderLanin left review comments

@LittleHuba LittleHuba LittleHuba left review comments

@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner

@qor-lb qor-lb Awaiting requested review from qor-lb qor-lb is a code owner

@johannes-esr johannes-esr Awaiting requested review from johannes-esr johannes-esr is a code owner

@markert-r markert-r Awaiting requested review from markert-r

@MaximilianSoerenPollak MaximilianSoerenPollak Awaiting requested review from MaximilianSoerenPollak

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix is a code owner

+4 more reviewers

@hth9fe hth9fe hth9fe left review comments

@crimson11 crimson11 crimson11 approved these changes

@opajonk opajonk opajonk approved these changes

@timkl7 timkl7 timkl7 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature_request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Modification for Cross-VM IPC

9 participants

@FScholPer @HartmannNico @LittleHuba @crimson11 @opajonk @AlexanderLanin @hth9fe @timkl7