-
Notifications
You must be signed in to change notification settings - Fork 74
Feature change SOME/IP GW remove AUTOSAR refs #2316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature change SOME/IP GW remove AUTOSAR refs #2316
Conversation
|
|
fd1612c to
e54ca4e
Compare
|
unintendedly closed, will reopen! |
|
The created documentation from the pull request is available at: docu-html |
|
@lurtz please also review and check if proposed changes are ok for you |
anmittag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is still one autosar reference in a diagram
docs/features/communication/some_ip_gateway/assets/e2e_state_machine_on_client_side.drawio.svg
Show resolved
Hide resolved
85491c7 to
d4ddbc3
Compare
NEOatNHNG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vsomeip doesn't contain an E2E implementation nor a "Payload Transformation".
For the payload transformation can implement a S-CORE payload transformation which is based e.g. on OpenSOMEIP spec and only supports a subset of the features for the MVP.
For the E2E we have to come up with a better plan. So far for E2E it would use "AUTOSAR" code (i.e. use a commercial stack).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that this PR also includes the addition of the "Code Generation" feature? Seems to be a separate topic to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad rebaseing by me! Rebased it again so this was removed.
|
|
||
| It also is a participant in the SOME/IP network and provides services for the service oriented communication. | ||
| This shall be possible by including SOME/IP stacks that are AUTOSAR compliant. | ||
| This shall be possible by including SOME/IP stacks from `vsomeip <https://github.com/COVESA/vsomeip>`_ for reference, which can be replaced by other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This shall be possible by including SOME/IP stacks from `vsomeip <https://github.com/COVESA/vsomeip>`_ for reference, which can be replaced by other | |
| This shall be possible by including the `vsomeip <https://github.com/COVESA/vsomeip>`_ SOME/IP stack for reference, which can be replaced by other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved this one. (Note, will not be able to resolve all the review findings in this PR, as I miss the necessary background on SOME/IP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vsomeip doesn't contain an E2E implementation nor a "Payload Transformation".
For the payload transformation can implement a S-CORE payload transformation which is based e.g. on OpenSOMEIP spec and only supports a subset of the features for the MVP.
For the E2E we have to come up with a better plan. So far for E2E it would use "AUTOSAR" code (i.e. use a commercial stack).
| CRC-protection and checks, and message counters. | ||
|
|
||
| There are several E2E (= End-to-End) profiles, which utilize various CRC routines as part of AUTOSAR E2E Protocol Specification, that shall be supported with the SOME/IP Gateway. | ||
| There are several E2E (= End-to-End) profiles, which utilize various CRC routines as part of E2E Protocol Specification, that shall be supported with the SOME/IP Gateway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E is still AUTOSAR only. So I guess here we need to stick to the previous wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specs on some-ip.com also refer to AUTOSAR, so this is actually AUTOSAR for the moment.
| - `AUTOSAR_FO_PRS_E2EProtocol <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_PRS_E2EProtocol.pdf>`_ | ||
| - `AUTOSAR_FO_RS_E2E <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_RS_E2E.pdf>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep references for E2E
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specs on some-ip.com also refer to AUTOSAR, so this is actually AUTOSAR for the moment.
| The E2E protection implementation shall be fully compatible and complying with the E2E protocol specification from AUTOSAR Adaptive Version 24-11. | ||
| - `AUTOSAR_FO_PRS_E2EProtocol <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_PRS_E2EProtocol.pdf>`_ | ||
| - `AUTOSAR_FO_RS_E2E <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_RS_E2E.pdf>`_ | ||
| The E2E protection implementation shall be fully compatible and complying with the E2E protocol specification from `some-ip.com <https://some-ip.com/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specs on some-ip.com also refer to AUTOSAR, so this is actually AUTOSAR for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is a different feature, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, did some wrong rebaseing. Changed the rebase again., this should now be resolved
removed references to AUTOSAR, now using vsomeip and some-ip.com . one more ref to AUTOSAR removed
74a946d to
abd8463
Compare
Minor correction from review finding. Signed-off-by: Philipp Ahmann <2428012+pahmann@users.noreply.github.com>
Removing references to Autosar specs and refering to vsomeip instead.
Resolves #2251