Skip to content

Conversation

@ZoranCutura
Copy link
Contributor

@ZoranCutura ZoranCutura commented Dec 9, 2025

Removing references to Autosar specs and refering to vsomeip instead.
Resolves #2251

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

@ZoranCutura ZoranCutura force-pushed the feature_change_some_ip_gw branch from fd1612c to e54ca4e Compare December 10, 2025 16:19
@ZoranCutura
Copy link
Contributor Author

unintendedly closed, will reopen!

@ZoranCutura ZoranCutura reopened this Dec 11, 2025
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@ZoranCutura ZoranCutura marked this pull request as ready for review December 11, 2025 14:01
@ZoranCutura
Copy link
Contributor Author

@lurtz please also review and check if proposed changes are ok for you

Copy link
Member

@anmittag anmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still one autosar reference in a diagram

@ZoranCutura ZoranCutura force-pushed the feature_change_some_ip_gw branch from 85491c7 to d4ddbc3 Compare December 17, 2025 16:09
LittleHuba
LittleHuba previously approved these changes Dec 17, 2025
Copy link

@NEOatNHNG NEOatNHNG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsomeip doesn't contain an E2E implementation nor a "Payload Transformation".
For the payload transformation can implement a S-CORE payload transformation which is based e.g. on OpenSOMEIP spec and only supports a subset of the features for the MVP.
For the E2E we have to come up with a better plan. So far for E2E it would use "AUTOSAR" code (i.e. use a commercial stack).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that this PR also includes the addition of the "Code Generation" feature? Seems to be a separate topic to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad rebaseing by me! Rebased it again so this was removed.


It also is a participant in the SOME/IP network and provides services for the service oriented communication.
This shall be possible by including SOME/IP stacks that are AUTOSAR compliant.
This shall be possible by including SOME/IP stacks from `vsomeip <https://github.com/COVESA/vsomeip>`_ for reference, which can be replaced by other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This shall be possible by including SOME/IP stacks from `vsomeip <https://github.com/COVESA/vsomeip>`_ for reference, which can be replaced by other
This shall be possible by including the `vsomeip <https://github.com/COVESA/vsomeip>`_ SOME/IP stack for reference, which can be replaced by other

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved this one. (Note, will not be able to resolve all the review findings in this PR, as I miss the necessary background on SOME/IP)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsomeip doesn't contain an E2E implementation nor a "Payload Transformation".
For the payload transformation can implement a S-CORE payload transformation which is based e.g. on OpenSOMEIP spec and only supports a subset of the features for the MVP.
For the E2E we have to come up with a better plan. So far for E2E it would use "AUTOSAR" code (i.e. use a commercial stack).

CRC-protection and checks, and message counters.

There are several E2E (= End-to-End) profiles, which utilize various CRC routines as part of AUTOSAR E2E Protocol Specification, that shall be supported with the SOME/IP Gateway.
There are several E2E (= End-to-End) profiles, which utilize various CRC routines as part of E2E Protocol Specification, that shall be supported with the SOME/IP Gateway.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E is still AUTOSAR only. So I guess here we need to stick to the previous wording.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specs on some-ip.com also refer to AUTOSAR, so this is actually AUTOSAR for the moment.

Comment on lines -234 to -235
- `AUTOSAR_FO_PRS_E2EProtocol <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_PRS_E2EProtocol.pdf>`_
- `AUTOSAR_FO_RS_E2E <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_RS_E2E.pdf>`_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep references for E2E

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specs on some-ip.com also refer to AUTOSAR, so this is actually AUTOSAR for the moment.

Comment on lines -62 to +60
The E2E protection implementation shall be fully compatible and complying with the E2E protocol specification from AUTOSAR Adaptive Version 24-11.
- `AUTOSAR_FO_PRS_E2EProtocol <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_PRS_E2EProtocol.pdf>`_
- `AUTOSAR_FO_RS_E2E <https://www.autosar.org/fileadmin/standards/R24-11/FO/AUTOSAR_FO_RS_E2E.pdf>`_
The E2E protection implementation shall be fully compatible and complying with the E2E protocol specification from `some-ip.com <https://some-ip.com/>`_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specs on some-ip.com also refer to AUTOSAR, so this is actually AUTOSAR for the moment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is a different feature, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, did some wrong rebaseing. Changed the rebase again., this should now be resolved

removed references to AUTOSAR, now using vsomeip and some-ip.com .
one more ref to AUTOSAR removed
@ZoranCutura ZoranCutura force-pushed the feature_change_some_ip_gw branch from 74a946d to abd8463 Compare December 19, 2025 09:51
Minor correction from review finding.

Signed-off-by: Philipp Ahmann <2428012+pahmann@users.noreply.github.com>
@FScholPer FScholPer merged commit 3266359 into eclipse-score:main Jan 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change: SOME/IP Feature should refer to vsomeip instead of AUTOSAR

6 participants