fixed http client write buffer failed. #5710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add a test for this ? |
wang007
force-pushed
the
http-client-chunked-fix
branch
4 times, most recently
from
87186c9 to
ba12447
Compare
done. |
wang007
force-pushed
the
http-client-chunked-fix
branch
from
ba12447 to
4c38c3f
Compare
|
thanks @wang007 can you avoid un-necessary code reformat in the pull request ? |
wang007
force-pushed
the
http-client-chunked-fix
branch
from
4c38c3f to
11b43ee
Compare
ok |
wang007
force-pushed
the
http-client-chunked-fix
branch
from
11b43ee to
4ddbecb
Compare
|
@vietj Could you review this pr? |
|
@wang007 can you make a single commit formatted with the title / motivation / changes for this PR ? |
Motivation: When using the vertx-http-proxy proxy for the h2 protocol, there is a bug in the handling of content-length when writing buffer. Modifications: HttpClientRequestImpl#write,HttpClientRequestImpl#requiresContentLength
wang007
force-pushed
the
http-client-chunked-fix
branch
from
7cbe714 to
1a3816b
Compare
|
@vietj Done. Please review this pr again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When using the vertx-http-proxy proxy for the h2 protocol, there is a bug in the handling of content-length when writing buffer.
Modifications: HttpClientRequestImpl#write,HttpClientRequestImpl#requiresContentLength
#5708