Add of() overloading with variable map entries. #5736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently the static method
JsonObject.of()
method has 10 different definitions to accept key value pairs as parameters to create a new JSON object. The new implementation of this method intends to ensure that we do not need 10 different definitions based on the number of parameters to create a JSON object. Instead, the new method implements an array of map entries (tuples) that consists of a key and a value corresponding to the key. It is possible to have multiple such map entries, so instead of defining theof()
method 10 times, this method should be declared only once with the ability to process a variable number of arguments.Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
I have signed the Eclipse Contributor Agreement.
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines
I am adhering to the code style guidelines.