Skip to content

Mark IDesignPage.getProgressMonitor() for removal #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptziegler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark IDesignPage.getProgressMonitor() for removal #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions org.eclipse.wb.core.java/src/org/eclipse/wb/internal/core/editor/DesignPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ private void internal_refreshGEF_withProgress() throws Exception {
final Display display = Display.getCurrent();
IRunnableWithProgress runnable = new IRunnableWithProgress() {
@Override
@SuppressWarnings("removal")
public void run(final IProgressMonitor monitor) throws InvocationTargetException,
InterruptedException {
monitor.beginTask("Opening Design page.", 7);
Expand Down
6 changes: 5 additions & 1 deletion org.eclipse.wb.core/src/org/eclipse/wb/core/editor/IDesignPageSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011 Google, Inc.
* Copyright (c) 2011, 2025 Google, Inc. and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License 2.0 which is available at
Expand Down Expand Up @@ -74,7 +74,11 @@ public static IDesignPageSite getSite(ObjectInfo objectInfo) {
* @return the {@link IProgressMonitor} to use for displaying progress during parsing (initiated
* by {@link IDesignPage}). If parsing was complete, or we run tests, then
* {@link NullProgressMonitor} will be returned. Never returns <code>null</code>.
* @deprecated The progress monitor should never be used outside of the parsing
* context. This method will be removed after the 2028-release.
*/
@SuppressWarnings("removal")
@Deprecated(forRemoval = true, since = "2026-03")
public static IProgressMonitor getProgressMonitor() {
return DesignPageSite.getProgressMonitor();
}
Expand Down
6 changes: 5 additions & 1 deletion org.eclipse.wb.core/src/org/eclipse/wb/internal/core/editor/DesignPageSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011 Google, Inc.
* Copyright (c) 2011, 2025 Google, Inc. and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License 2.0 which is available at
Expand Down Expand Up @@ -128,7 +128,9 @@ public static void setSite(ObjectInfo objectInfo, IDesignPageSite site) {
* @return the {@link IProgressMonitor} to use for displaying progress during parsing (initiated
* by {@link IDesignPage}). If parsing was complete, or we run tests, then
* {@link NullProgressMonitor} will be returned. Never returns <code>null</code>.
* @deprecated The progress monitor should never be used outside of the parsing context.
*/
@Deprecated(forRemoval = true, since = "2026-03")
public static IProgressMonitor getProgressMonitor() {
return m_progressMonitor != null ? m_progressMonitor : NULL_PROGRESS_MONITOR;
}
Expand All @@ -139,7 +141,9 @@ public static IProgressMonitor getProgressMonitor() {
*
* @param progressMonitor
* the {@link IProgressMonitor} to use, may be <code>null</code>.
* @deprecated The progress monitor should never be used outside of the parsing context.
*/
@Deprecated(forRemoval = true, since = "2026-03")
public static void setProgressMonitor(IProgressMonitor progressMonitor) {
m_progressMonitor = progressMonitor;
}
Expand Down
Loading