Skip to content

perf: improvements in util.js #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: improvements in util.js #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/core/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var nativeFilter = arrayProto.filter;
var nativeSlice = arrayProto.slice;
var nativeMap = arrayProto.map;
var nativeReduce = arrayProto.reduce;
var nativeFind = arrayProto.find;

// Avoid assign to an exported variable, for transforming to cjs.
var methods = {};
Expand Down Expand Up @@ -393,9 +394,13 @@ export function find(obj, cb, context) {
if (!(obj && cb)) {
return;
}
for (var i = 0, len = obj.length; i < len; i++) {
if (cb.call(context, obj[i], i, obj)) {
return obj[i];
if (obj.find && obj.find === nativeFind) {
return obj.find(cb, context);
} else {
for (var i = 0, len = obj.length; i < len; i++) {
if (cb.call(context, obj[i], i, obj)) {
return obj[i];
}
}
}
}
Expand All @@ -412,6 +417,10 @@ export function bind(func, context) {
return func.apply(context, args.concat(nativeSlice.call(arguments)));
};
}
if (bind.bind) {
// https://jsben.ch/sEcop
bind = bind.call.bind(bind.bind);
}

/**
* @memberOf module:zrender/core/util
Expand All @@ -421,6 +430,20 @@ export function bind(func, context) {
export function curry(func) {
var args = nativeSlice.call(arguments, 1);
return function () {
// https://jsben.ch/bumDU
if (args.length === 1) {
switch (arguments.length) {
case 1: return func.call(this, args[0], arguments[0]);
case 2: return func.call(this, args[0], arguments[0], arguments[1]);
case 3: return func.call(this, args[0], arguments[0], arguments[1], arguments[2]);
}
} else if (args.length === 2) {
switch (arguments.length) {
case 1: return func.call(this, args[0], args[1], arguments[0]);
case 2: return func.call(this, args[0], args[1], arguments[0], arguments[1]);
case 3: return func.call(this, args[0], args[1], arguments[0], arguments[1], arguments[2]);
}
}
return func.apply(this, args.concat(nativeSlice.call(arguments)));
};
}
Expand Down