Skip to content

bugfix: lightbeam send not writing >=7.2 API error messages when error payload does not contain errors nor validationErrors #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: lightbeam send not writing >=7.2 API error messages when error payload does not contain errors nor validationErrors #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### Unreleased changes
<details>
* bugfix: `lightbeam send` not writing >=7.2 API error messages when error payload does not contain `errors` nor `validationErrors`
</details>

### v0.1.9
<details>
<summary>Released 2025-09-26</summary>
Expand Down
5 changes: 5 additions & 0 deletions lightbeam/send.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ async def do_post(self, endpoint, file_name, data, line_number, data_hash):
# (Ed-Fi API <= 7.1 style errors)
messages.append(str(response.status) + ": " + util.linearize(response_body.get("message", "")))

elif "detail" in response_body:
# (Ed-Fi API >= 7.2 style errors fallback.
# All error payloads should contain this key, though it's not guaranteed to be informative
messages.append(str(response.status) + ": " + util.linearize(response_body.get("detail", "")))

# update run metadata...
failures = self.lightbeam.metadata["resources"][endpoint].get("failures", [])
for message in messages:
Expand Down