Skip to content

Conversation

@mipo256
Copy link
Member

@mipo256 mipo256 commented Dec 19, 2024

Clarified the behavior of glob expressions


📚 Documentation preview 📚: https://editorconfig-specification--67.org.readthedocs.build/

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of wording changes

@mipo256
Copy link
Member Author

mipo256 commented Dec 20, 2024

Thanks @xuhdev!
I've applied your suggestions. Please, re-review.

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed one markup, everything LGTM

@mipo256
Copy link
Member Author

mipo256 commented Dec 23, 2024

hey @xuhdev applied the suggestion and squashed the commit, please, re-review :)

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@xuhdev xuhdev merged commit 21749e9 into editorconfig:master Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants