-
Notifications
You must be signed in to change notification settings - Fork 29
Added a small section addressing empty editorconfig files #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
index.rst
Outdated
| Non-existing directories are treated as if they exist and are empty. All found | ||
| EditorConfig files are searched for sections with section names matching the | ||
| given filename. The search shall stop if an EditorConfig file is found with | ||
| EditorConfig files are searched for sections with section glob expressions matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a different topic than "empty editorconfig files." Would you please move it to a separate PR? That would make the git history cleaner, and this PR more focused. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, now that I think about it more, I believe this should stay as it was. "Section name" is defined above (here). Using the term in this paragraph is therefore unambiguous.
Consider the section name [{*.txt,*.md}]. At the command prompt, I would think of that as two "glob expression"s (*.txt and *.md). However, in this paragraph the whole name {...} is taken as a unit. I worry that if we made this change it might confuse readers. Sorry for the late change!
|
@mipo256 Apologies for the confusion --- I hit Submit too soon. Please see #87 (comment) . I thought about it some more and realized I think "section name" should stay as it is --- details in that comment. Thanks! |
|
I agree with you, @cxw42. I think it makes sense to retain the "section name" change to retain as it is. However, the section name, as I see it, is a single glob expression, that contains the multiple parts, like the following:
It is not fully accurate, these are parts of a single glob (I might be wrong, but this is as far as I see it). But at the end of the day, I see your suggestion as a good way to go. I rolled back the change. |
|
@mipo256 thanks! Yes, I agree the phrase "glob expression" could be interpreted multiple ways. |
Closes #86
CC: @xuhdev
📚 Documentation preview 📚: https://editorconfig-specification--87.org.readthedocs.build/