Make request I/O pure and expose the fd #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
commented
Jun 12, 2017
| | exn -> | ||
| log_error ("Unknown exception caught: "^(Printexc.to_string exn)); | ||
| IO.(Out.write_error log_error req Errno.EIO | ||
| >>= fun () -> fail exn) |
Author
There was a problem hiding this comment.
FYI this line is the only reason why requests return a response list, instead of just a single response.
Member
There was a problem hiding this comment.
Ah yes, this mechanism is rather messy... I think it can probably be simplified but continue your work as-is for now.
Author
There was a problem hiding this comment.
One option for faithfully encoding this without a list is to add another variand, something like `Error_and_raise _.
Signed-off-by: Anton Bachin <antonbachin@yahoo.com>
Signed-off-by: Anton Bachin <antonbachin@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispatchand helpers so that they do not write to the request fd. Instead, they return lists of writing operations, to be performed by the same outer code that reads from the fd, and callsdispatch.