-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate to oxlint JavaScript plugins support #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
@copilot should add tests with oxlint |
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Added comprehensive oxlint tests in commit ab0f05f. The test suite includes:
All 23 tests pass (19 original + 4 new oxlint tests). |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This PR adds support for oxlint's JavaScript plugin system, making
eslint-plugin-eggache
compatible with both ESLint and oxlint.Changes
Package Metadata
package.json
description to mention oxlint compatibilityoxlint
,eslint
,eslintplugin
,eggjs
,egg
) for better discoverabilityoxlint
as dev dependency (v1.22.0)test:oxlint
npm script for oxlint-specific testingPlugin Metadata
meta
field to plugin export withname
andversion
(required by oxlint's JavaScript plugin loader)Rule Metadata Improvements
Enhanced all three rules (
no-only-tests
,no-override-exports
,no-unexpected-plugin-keys
) with proper metadata:type: 'problem'
field to meta section for better linter compatibilityfixable
field inno-only-tests
fromtrue
to'code'
(proper ESLint/oxlint format)Documentation
Updated README.md with comprehensive oxlint support:
Oxlint Tests
Added comprehensive oxlint integration test suite in
test/oxlint/
:meta.name
,meta.version
)meta.type
,meta.docs
,create
).oxlintrc.json
) for testing.eslintignore
to exclude test fixtures (they contain intentional violations)Compatibility
The plugin maintains 100% backward compatibility with ESLint while adding full support for oxlint. The existing plugin structure was already ESLint-compliant, requiring only minimal metadata and documentation updates.
Testing
Users can now seamlessly use this plugin with either ESLint or oxlint!
Fixes #7
Original prompt
Fixes #7
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.