Skip to content

Add option to required MX record on DNSCheckValidation #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Add option to required MX record on DNSCheckValidation #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Validation/DNSCheckValidation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ class DNSCheckValidation implements EmailValidation
*/
private $dnsGetRecord;

public function __construct(?DNSGetRecordWrapper $dnsGetRecord = null)
/**
* @var bool
*/
private $requireMX;

public function __construct(?DNSGetRecordWrapper $dnsGetRecord = null, bool $requireMX = false)
{
if (!function_exists('idn_to_ascii')) {
throw new \LogicException(sprintf('The %s class requires the Intl extension.', __CLASS__));
Expand All @@ -74,6 +79,7 @@ public function __construct(?DNSGetRecordWrapper $dnsGetRecord = null)
}

$this->dnsGetRecord = $dnsGetRecord;
$this->requireMX = $requireMX;
}

public function isValid(string $email, EmailLexer $emailLexer): bool
Expand Down Expand Up @@ -174,6 +180,11 @@ private function validateDnsRecords($host): bool
return false;
}
}

if (empty($this->mxRecords) && $this->requireMX) {
$this->error = new InvalidEmail(new ReasonNoDNSRecord(), '');
}

return true;
}

Expand Down