[Feature] increase menu load speed when no emoji change beetween two pages #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple callback
mrsolarius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the speed of loading embed menu when no reaction change between two. It's possible because when no reaction change they are no need to call
addReactions()and this method take 0,2 to 0,7 second to be executed multiply by number of emoji.So, I have to convert
reactionsChangedvar to a class attribute and I use it to not calladdReactions()onsetPage()methodI also update dependency version to be able to correctly generate the documentation.
Finally, I have regenerated docs and code distribution