Skip to content

DateFieldMapper: unmute test whose failure is no longer relevant, remove unused code #138313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2025
Merged

DateFieldMapper: unmute test whose failure is no longer relevant, remove unused code #138313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6c2c8f
DateFieldMapper: unmute test whose failure is no longer relevant, rem…
GalLalouche Nov 19, 2025
8de97e6
Merge branch 'main' into unumute_date_field_mapper
GalLalouche Nov 20, 2025
e136966
Merge branch 'main' into unumute_date_field_mapper
GalLalouche Nov 20, 2025
55df503
Merge branch 'main' into unumute_date_field_mapper
GalLalouche Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,6 @@ tests:
- class: org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorIT
method: testCreatesChatCompletion_AndThenCreatesTextEmbedding
issue: https://github.com/elastic/elasticsearch/issues/138012
- class: org.elasticsearch.index.mapper.DateFieldMapperTests
method: testSortShortcuts
issue: https://github.com/elastic/elasticsearch/issues/138018
- class: org.elasticsearch.xpack.ml.integration.ForecastIT
method: testOverflowToDisk
issue: https://github.com/elastic/elasticsearch/issues/138055
Expand Down
9 changes: 0 additions & 9 deletions server/src/test/java/org/elasticsearch/index/mapper/DateFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import org.apache.lucene.index.IndexWriterConfig;
import org.apache.lucene.index.IndexableField;
import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.search.DocIdSetIterator;
import org.apache.lucene.search.Sort;
import org.apache.lucene.search.SortField;
import org.apache.lucene.store.Directory;
Expand All @@ -35,7 +34,6 @@
import org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormat;
import org.elasticsearch.index.mapper.DateFieldMapper.DateFieldType;
import org.elasticsearch.index.mapper.blockloader.docvalues.LongsBlockLoader;
import org.elasticsearch.lucene.comparators.XUpdateableDocIdSetIterator;
import org.elasticsearch.script.DateFieldScript;
import org.elasticsearch.script.ScriptService;
import org.elasticsearch.search.DocValueFormat;
Expand All @@ -51,7 +49,6 @@
import java.time.ZonedDateTime;
import java.util.Comparator;
import java.util.List;
import java.util.function.Consumer;
import java.util.stream.IntStream;
import java.util.stream.Stream;

Expand Down Expand Up @@ -919,12 +916,6 @@ public void testSingletonLongBulkBlockReadingManyValues() throws Exception {
}
}

private static final Consumer<DocIdSetIterator> checkClass = disi -> {
assertThat(disi, instanceOf(XUpdateableDocIdSetIterator.class));
XUpdateableDocIdSetIterator iterator = (XUpdateableDocIdSetIterator) disi;
assertThat(iterator.getDelegate().getClass().getName(), containsString("SecondarySortIterator"));
};

@Override
protected List<SortShortcutSupport> getSortShortcutSupport() {
return List.of(
Expand Down