Skip to content

New httpcheck OTel input package #15785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

New httpcheck OTel input package #15785

wants to merge 4 commits into from

Conversation

@jsoriano
Copy link
Member

Proposed commit message

New OTel input package for the HTTP Check Receiver.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@jsoriano jsoriano requested a review from ishleenk17 October 28, 2025 12:35
@jsoriano jsoriano self-assigned this Oct 28, 2025
@jsoriano jsoriano requested a review from a team as a code owner October 28, 2025 12:35
@jsoriano jsoriano force-pushed the new-httpcheck-package branch from 06ab133 to c12feee Compare October 28, 2025 12:36
@jsoriano jsoriano requested a review from a team October 28, 2025 13:07
@jsoriano jsoriano changed the title New httpcheck OTel package New httpcheck OTel input package Oct 28, 2025
@andrewkroh andrewkroh added New Integration Issue or pull request for creating a new integration package. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels Oct 28, 2025
ishleenk17
ishleenk17 reviewed Oct 29, 2025
View reviewed changes
packages/httpcheck/manifest.yml
categories:
- monitoring
- network
- web
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add opentelemtry category

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 209e7cf.

packages/httpcheck/sample_event.json Outdated
"http.url": "http://svc-web:80"
},
"data_stream": {
"dataset": "httpcheck.httpcheckreceiver.otel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be httpcheckreceiver.otel ?

Copy link
Member Author

@jsoriano jsoriano Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a real case it will indeed be httpcheckreceiver.otel.

Here this document is obtained with elastic-package test system, what is configuring the dataset as <package name>.<policy template name> for legacy reasons.

I have created a follow up issue about this, I think we should fix this discrepancy at some point: elastic/elastic-package#3036

packages/httpcheck/_dev/test/policy/test-eprcheck.yml
@@ -0,0 +1,3 @@
vars:
endpoints:
- https://epr.elastic.co
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test for input package is going to be if the policy is correctly formed ?
Any data related check we plan to add ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test for input package is going to be if the policy is correctly formed ?

This kind of test is available also for integration packages, is not specific to input packages.

Any data related check we plan to add ?

System tests are the closest thing to a data related check that we have at the moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, policy tests are not intended to collect any data, they only create a policy with some given variables and check that the generated agent policy is the expected one.

packages/httpcheck/_dev/test/policy/test-eprcheck.expected
connectors:
forward: {}
exporters:
elasticsearch/componentid-0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these componentid-0 ? Fetched from epr ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet generates this configuration with randomized component ids. Here elastic-package is replacing the random part with predictable strings so they can be compared in tests.

@elasticmachine
Copy link

elasticmachine commented Oct 29, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @jsoriano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishleenk17 ishleenk17 ishleenk17 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jsoriano jsoriano

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsoriano @elasticmachine @ishleenk17 @andrewkroh