Skip to content

Conversation

@mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Oct 28, 2025

Proposed commit message

Correct the sslvpn ingest pipeline to properly handle events where the event contains a failed status.
Previously, the pipeline was expecting a single word, which is used for "Passed" status, but failed status has multiple words, to explain the problem. The pipeline will now handle multi-word status.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Fix the sslvpn ingest pipeline to properly handle events where the event
contains a failed status.
@mjwolf mjwolf requested review from a team as code owners October 28, 2025 19:44
@mjwolf mjwolf added bugfix Pull request that fixes a bug issue Integration:citrix_adc Citrix ADC Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Oct 28, 2025
@elasticmachine
Copy link

Pinging @elastic/integration-experience (Team:Integration-Experience)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 28, 2025

🚀 Benchmarks report

Package citrix_adc 👍(3) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
interface 5405.41 4310.34 -1095.07 (-20.26%) 💔
lbvserver 6097.56 5000 -1097.56 (-18%) 💔

To see the full report comment with /test benchmark fullreport

@mjwolf mjwolf requested a review from taylor-swanson October 29, 2025 22:00
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjwolf mjwolf enabled auto-merge (squash) October 30, 2025 16:47
@elasticmachine
Copy link

💚 Build Succeeded

History

@mjwolf mjwolf merged commit cbe3223 into elastic:main Oct 30, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package citrix_adc - 1.17.5 containing this change is available at https://epr.elastic.co/package/citrix_adc/1.17.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:citrix_adc Citrix ADC Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants