-
Notifications
You must be signed in to change notification settings - Fork 508
[citrix_adc] Handled failed status in sslvpn pipeline #15786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the sslvpn ingest pipeline to properly handle events where the event contains a failed status.
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
interface |
5405.41 | 4310.34 | -1095.07 (-20.26%) | 💔 |
lbvserver |
6097.56 | 5000 | -1097.56 (-18%) | 💔 |
To see the full report comment with /test benchmark fullreport
.../citrix_adc/data_stream/log/_dev/test/pipeline/test-citrix-waf-native-14-1.log-expected.json
Outdated
Show resolved
Hide resolved
taylor-swanson
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
History
|
|
Package citrix_adc - 1.17.5 containing this change is available at https://epr.elastic.co/package/citrix_adc/1.17.5/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Pull request that fixes a bug issue
Integration:citrix_adc
Citrix ADC
Team:Integration-Experience
Security Integrations Integration Experience [elastic/integration-experience]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Correct the sslvpn ingest pipeline to properly handle events where the event contains a failed status.
Previously, the pipeline was expecting a single word, which is used for "Passed" status, but failed status has multiple words, to explain the problem. The pipeline will now handle multi-word status.
Checklist
changelog.ymlfile.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices