Skip to content

[Fleet] Improve space awareness tests speed and debugability #237498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 6, 2025
+325 −270
Merged

[Fleet] Improve space awareness tests speed and debugability #237498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9c44dd
[Fleet] Improve space awareness tests debugability
nchaulet Oct 3, 2025
151e653
improve space creation
nchaulet Oct 3, 2025
8e2bcba
fix test
nchaulet Oct 3, 2025
fcb1a0f
Merge branch 'main' into feature-improve-space-awareness-api-tests
elasticmachine Oct 3, 2025
86b8c69
fix types
nchaulet Oct 3, 2025
7151712
Merge branch 'main' into feature-improve-space-awareness-api-tests
elasticmachine Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/platform/test/fleet_api_integration/apis/agent_policy/create_standalone_api_key.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function (providerContext: FtrProviderContext) {
});
await expectToRejectWithError(
() => apiClient.postStandaloneApiKey('tata'),
/403 Forbidden Missing permissions to create standalone API key/
/403 "Forbidden" Missing permissions to create standalone API key/
);
});
});
Expand Down
3 changes: 2 additions & 1 deletion x-pack/platform/test/fleet_api_integration/apis/space_awareness/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
cleanFleetAgentPolicies,
cleanFleetIndices,
createFleetAgent,
createTestSpace,
} from './helpers';

export default function (providerContext: FtrProviderContext) {
Expand Down Expand Up @@ -62,7 +63,7 @@ export default function (providerContext: FtrProviderContext) {
testSpaceAgent1 = _testSpaceAgent1;
testSpaceAgent2 = _testSpaceAgent2;

await spaces.createTestSpace(TEST_SPACE_1);
await createTestSpace(providerContext, TEST_SPACE_1);
});

beforeEach(async () => {
Expand Down
9 changes: 7 additions & 2 deletions x-pack/platform/test/fleet_api_integration/apis/space_awareness/agent_policies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ import type { CreateAgentPolicyResponse } from '@kbn/fleet-plugin/common';
import type { FtrProviderContext } from '../../../api_integration/ftr_provider_context';
import { skipIfNoDockerRegistry } from '../../helpers';
import { SpaceTestApiClient } from './api_helper';
import { cleanFleetIndices, expectToRejectWithError, expectToRejectWithNotFound } from './helpers';
import {
cleanFleetIndices,
createTestSpace,
expectToRejectWithError,
expectToRejectWithNotFound,
} from './helpers';
import { setupTestUsers, testUsers } from '../test_users';

export default function (providerContext: FtrProviderContext) {
Expand Down Expand Up @@ -52,7 +57,7 @@ export default function (providerContext: FtrProviderContext) {

await apiClient.postEnableSpaceAwareness();

await spaces.createTestSpace(TEST_SPACE_1);
await createTestSpace(providerContext, TEST_SPACE_1);
const [
_defaultSpacePolicy1,
_spaceTest1Policy1,
Expand Down
4 changes: 2 additions & 2 deletions ...k/platform/test/fleet_api_integration/apis/space_awareness/agent_policies_side_effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type { CreateAgentPolicyResponse } from '@kbn/fleet-plugin/common';
import type { FtrProviderContext } from '../../../api_integration/ftr_provider_context';
import { skipIfNoDockerRegistry } from '../../helpers';
import { SpaceTestApiClient } from './api_helper';
import { cleanFleetIndices } from './helpers';
import { cleanFleetIndices, createTestSpace } from './helpers';

export default function (providerContext: FtrProviderContext) {
const { getService } = providerContext;
Expand All @@ -36,7 +36,7 @@ export default function (providerContext: FtrProviderContext) {
await cleanFleetIndices(esClient);

await apiClient.postEnableSpaceAwareness();
await spaces.createTestSpace(TEST_SPACE_1);
await createTestSpace(providerContext, TEST_SPACE_1);

const [_defaultSpacePolicy1, _spaceTest1Policy1] = await Promise.all([
apiClient.createAgentPolicy(),
Expand Down
3 changes: 2 additions & 1 deletion x-pack/platform/test/fleet_api_integration/apis/space_awareness/agents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
cleanFleetAgents,
cleanFleetIndices,
createFleetAgent,
createTestSpace,
makeAgentsUpgradeable,
} from './helpers';
import { pollResult } from '../agents/update_agent_tags';
Expand Down Expand Up @@ -50,7 +51,7 @@ export default function (providerContext: FtrProviderContext) {
space: TEST_SPACE_1,
});
await cleanFleetIndices(esClient);
await spaces.createTestSpace(TEST_SPACE_1);
await createTestSpace(providerContext, TEST_SPACE_1);

await apiClient.postEnableSpaceAwareness();

Expand Down
Loading
Loading