Skip to content

[9.2] [dashboards] fix panels in sections from URL state are not transformed (#237382) #237510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 9.2
Choose a base branch
from
Open

[9.2] [dashboards] fix panels in sections from URL state are not transformed (#237382) #237510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions ...atform/plugins/shared/dashboard/public/dashboard_app/url/bwc/extract_panels_state.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,49 @@ describe('extractPanelsState', () => {
});
});

describe('8.19', () => {
test('should migrate panels in sections', () => {
const { panels } = extractPanelsState({
panels: [
{
title: 'Section 1',
gridData: {},
panels: [
{
embeddableConfig: {
timeRange: {
from: 'now-7d/d',
to: 'now',
},
},
gridData: {},
type: 'map',
},
],
},
],
});
expect(panels).toEqual([
{
title: 'Section 1',
grid: {},
panels: [
{
config: {
timeRange: {
from: 'now-7d/d',
to: 'now',
},
},
grid: {},
type: 'map',
},
],
},
]);
});
});

describe('< 8.19 panels state', () => {
test('should move id and title to config', () => {
const { panels } = extractPanelsState({
Expand Down
7 changes: 7 additions & 0 deletions src/platform/plugins/shared/dashboard/public/dashboard_app/url/bwc/extract_panels_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ export function extractPanelsState(state: { [key: string]: unknown }): {
const standardizedPanels: DashboardState['panels'] = panels.map((legacyPanel) => {
const panel = typeof legacyPanel === 'object' ? { ...legacyPanel } : {};

if (panel.panels) {
const { panels: sectionPanels, savedObjectReferences: sectionPanelReferences } =
extractPanelsState({ panels: panel.panels });
savedObjectReferences.push(...(sectionPanelReferences ?? []));
panel.panels = sectionPanels;
}

// < 8.17 panels state stored panelConfig as embeddableConfig
if (panel?.embeddableConfig) {
panel.config = panel.embeddableConfig;
Expand Down