Skip to content

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Oct 9, 2025

These changes move the two options jruby.compile.invokedynamic and log4j2.isThreadContextMapInheritable from jvm.options to code.

The changes also include setting invokedynamic for testing.

See #16788 for motivation

Resolves #16788

Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@estolfo estolfo requested a review from robbavey October 9, 2025 13:24
Copy link
Contributor

mergify bot commented Oct 9, 2025

This pull request does not have a backport label. Could you fix it @estolfo? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to move the log4j system property into build.gradle too. Sorry, I missed that during our slack conversation

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@estolfo estolfo requested a review from robbavey October 13, 2025 12:30
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estolfo estolfo merged commit 15b4e05 into elastic:main Oct 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jvm.optionsand startup.options values should have sensible defaults in code

3 participants