profilingmetrics: add syscall metric #834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
profilingmetrics-kernel
branch
from
8f4c949 to
5f2af53
Compare
christos68k
reviewed
Oct 21, 2025
| metricBeam = metric{name: "samples.beam.count", desc: "Number of samples executing Beam code (self)"} | ||
| metricUser = metric{name: "samples.user.count", desc: "Number of samples executing userspace code (self)"} | ||
| metricKernel = metric{name: "samples.kernel.count", desc: "Number of samples executing kernel code (self)"} | ||
| metricSyscall = metric{name: "samples.syscall.count", desc: "Number of samples executing syscall code (self)"} |
Member
There was a problem hiding this comment.
Instead of adding one more metric, we can use the same method as metricNative: We know that there can not be multiple syscalls per stacktrace, so we can enrich metricKernel with the syscall name attribute.
We can do that inside classifyFrame (which we can rename to classifyFrames) and have it take an extra argument kernelCounts map[string]int64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.