Add resource to manage ML datafeed state #1422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-benoit
approved these changes
Nov 8, 2025
Contributor
nick-benoit
left a comment
nick-benoit
left a comment
There was a problem hiding this comment.
Nice. Having the resource to manage the state is a cool idea. Just a few optional questions / thoughts.
| // waitForDatafeedState waits for a datafeed to reach the desired state | ||
| func (r *datafeedResource) waitForDatafeedState(ctx context.Context, datafeedId, desiredState string) error { | ||
| var terminalDatafeedStates = map[string]struct{}{ | ||
| "stopped": {}, |
Contributor
There was a problem hiding this comment.
Nit: I wonder if these should be constants defined somewhere?
| "github.com/hashicorp/terraform-plugin-testing/helper/resource" | ||
| "github.com/hashicorp/terraform-plugin-testing/terraform" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Is there a good way to add test coverage for datafeed_timeout and timeouts? I guess since they aren't written to any particular resource we read back from ES it might be a bit tricky. It would be nice to have some test coverage though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813