perf: run hashing and lipo in parallel #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radex
commented
Jan 30, 2023
| await fs.realpath(path.resolve(tmpApp, machOFile.relativePath)), | ||
| ]); | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
I recommend viewing this diff in "hide whitespace" mode
erickzhao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lipo-ing one binary does not depend on the output of previouslipo, so we can safely run it in parallel. Nothing fancy is required for that, just moving from awaiting sequentially to awaiting an array of promises. This gives an awesome speedup.