fix: handle darwin releases with only universal builds #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
reviewed
Oct 4, 2025
| PLATFORM_ARCH.DARWIN_UNIVERSAL, | ||
| version | ||
| ); | ||
| latest = latest || latestUniversal; |
There was a problem hiding this comment.
could you add a regression test for this?
There was a problem hiding this comment.
Regression test is in here --> #192
|
I think this might supersede #185 as well? Worth comparing the two solutions and merging the better one. |
|
@erickzhao I looked at that one, and it didn't fix the issue I was seeing. Gonna land this one and close that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bunch of 500 errors on the darwin endpoints, this ensures that
latestis defined as the universal one if there isn't otherwise a "latest" build available.Closes #184