Add upstream_oauth2.providers.[].client_secret_file config option
#4882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
networkException
force-pushed
the
upstream-providers-client-secret-file
branch
3 times, most recently
from
c648605 to
b0e7eb1
Compare
networkException
force-pushed
the
upstream-providers-client-secret-file
branch
from
b0e7eb1 to
d0548a9
Compare
networkException
force-pushed
the
upstream-providers-client-secret-file
branch
from
d0548a9 to
f657012
Compare
sandhose
requested changes
Nov 6, 2025
Member
sandhose
left a comment
sandhose
left a comment
There was a problem hiding this comment.
Very sorry for the delay on the review, but thank you very much for this! Could I just ask you to update the docs with the new option as well? https://element-hq.github.io/matrix-authentication-service/reference/configuration.html#upstream_oauth2providers
sandhose
added
A-Configuration
This patch factors out the previously introduced config wrapper for client secrets to also use it for upstream oauth providers. See a7e7c3c
networkException
force-pushed
the
upstream-providers-client-secret-file
branch
from
f657012 to
b5a0834
Compare
Contributor
Author
|
I rebased onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request factors out the previously introduced config wrapper for client secrets to also use it for upstream oauth providers.
See a7e7c3c
Disclosure: I work for the German government agency FITKO where I also participate in the Matrix Community. This pull request is written and published by me personally without my work hat on.