Skip to content

Fix meson warning for run_command #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turbobastii wants to merge 1 commit into
base: jammy
Choose a base branch
from
Open

Fix meson warning for run_command #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
project('appstream-data-pantheon')

run_script = run_command('bash', meson.project_name() + '.sh')
run_script = run_command('bash', meson.project_name() + '.sh', check: false)
Copy link

@eli-schwartz eli-schwartz Oct 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script doesn't even exist, so it always fails. What's it supposed to do? What's the result of running Meson?

The script was removed in commit b616c8c for the record. Setting this to check: true would reveal that failure. ;)

Copy link
Author

@turbobastii turbobastii Oct 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, that's what I get by somewhat blindly scanning the repos for the run_command issue without fully understanding the repo first. 😅️
Looking at the commit you mentioned, it seems to me, as if the entire meson part is not needed anymore. Do you think it would be good to just remove the meson.build file?

Copy link

@eli-schwartz eli-schwartz Oct 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably?

Either that or reimplement it from scratch to install the relevant contents of pantheon-data/main/