Support the settings portal where is possible #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows granite to use the host settings when running sandboxed
Contributor
|
Can you look at merging this with #528 ? I don't think you need a new Portal Settings class, the existing Settings class is probably fine. |
Contributor
Author
I think #528 is out of scope for this PR, since this aren't adding a new API, but just making the current functions use the portal. However i can rebase it on top of #527.
I made it this way so that we declare the interface (and any other interface we need) just in one place. |
This was referenced Oct 6, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by elementary/settings-daemon#38
This make the functions that read some setting provided by the portal to try it first, allowing we get the right values when sandboxed.