Add support for multiarch downloads in 8.1 #3922
Conversation
Updated margin styles for dialog options and titles.
|
This still needs a close buttom (clicking outside the dialog doesn't work). |
Updated the download modal text to clarify the choice of OS variant.
|
Removed extra padding-top from the element.
|
|
I feel like a text "Close" button, like in #3920, would be better since clicking outside of the modal doesn't close it and the x on top left is a really small target and is almost missable for someone coming from Windows and not yet used to the close on the left design. (Also I don't like how it looks above the download icon, but that might be just me 😅) Aesthetics wise, I think I can see it either aligned with the Download buttons only, full width below the magnet buttons too, or same width as Download but aligned right. The last one might actually differentiate it the best, if it doesn't look too weird. |
|
How wide does the page have to be in order for the buttons to spread out to be inline? I'm looking on my laptop (16 inch MBP) and they keep coming up below the text (which could have more space between them) Don't mind the broken link button thats my setup 🙈 |
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I'm having trouble building the website but approving anyways since this just merges into the 8.1 branch so we can always iterate on it before the big merge
* Update for 8.1 * Update release details for version 8.1 Updated release filename, magnet link, and SHA256 hash for the new version. * Add support for multiarch downloads in 8.1 (#3922) * Add download options for Intel, AMD, and ARM 64-bit * Refactor dialog styles for better option layout * Reorder release information in config example * Refactor dialog option styles for better specificity * Adjust dialog option margins and styles Updated margin styles for dialog options and titles. * Revise download modal content for clarity Updated the download modal text to clarify the choice of OS variant. * Increase max-width of dialog paragraph * Update download modal title for clarity * Add close button to download modal in index.php * Remove padding-top from main.css Removed extra padding-top from the element. * Update links, press page, screenshots * Actually do screenshots * fix missing icons * Update dialog css * Invert options: best option for most people in bottom right * Better close button * Update copy * Add alt and set autofocus * Use HTML for close button * Delete _images/thirdparty-icons/apps/48/installer.svg --------- Co-authored-by: Lewis Goddard <lewisgoddard@eustasy.org>
Fixes #3845
Changes Summary
This pull reques is not ready for review.