Skip to content

DisplayWidget: show separate icon for VPN #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

DisplayWidget: show separate icon for VPN #274

wants to merge 16 commits into from

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 20, 2023 •
edited
Loading

Fixes #120

@danirabbit danirabbit requested a review from a team February 20, 2023 18:00
tintou
tintou requested changes Feb 22, 2023
View reviewed changes
@danirabbit danirabbit requested a review from tintou February 22, 2023 18:44
@zeebok
Copy link
Contributor

zeebok commented May 23, 2024 •
edited
Loading

The code looks good but when I tested with my ProtonVPN app in a VPN, nothing seems to get revealed. I can confirm that on OS7 using the app does update the indicator icon. The only difference that I can think of between the two is that the VM is connected by "ethernet" so it has a different icon but I would expect this to not matter.

It does show up in the indicator menu on the VM though so it definitely is seeing the connection to the VPN

@danirabbit danirabbit added this to OS 9 May 3, 2025
@danirabbit danirabbit moved this to In progress in OS 9 May 3, 2025
zeebok
zeebok reviewed Aug 3, 2025
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this again and it errors because you still have the hi-dpi for network-wired-secure-symbolic.svg still in gresource.

I still don't see a vpn icon reveal when I connect to ProtonVPN on my OS8 install. I thought maybe this was because it wasn't added to the DisplayWidget but that doesn't seem to change anything.

Additionally the tooltip for middle-click to go to airplane mode did not seemed to not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeebok zeebok zeebok left review comments

@tintou tintou Awaiting requested review from tintou

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

OS 9
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate VPN icon from network icon

3 participants

@danirabbit @zeebok @tintou