WifiInterface: use SettingsToggle

[danirabbit]

Fixes #23
Fixes #299

Uses a SettingsToggle for Wifi interfaces:

Available APs are shown in a context menu:

[stsdc]

Context menu over Popover feels like too many layers.
IMHO the list of 3-5 last used/most signal strength AP should be in the popover #163. Then, a link to wifi settings to provide the full list.

The radical solution would be to just remove AP list completely from the popover. Instead open WiFi settings. Because how often do we switch WiFis on PC?

[danirabbit]

I think submenus are pretty normal 🤷🏻‍♀️ in iOS control center the AP list is actually in the 3rd level submenu

There's kind of some issues currently when you have multiple WiFi devices about which device you want to connect when you select an AP, so that's why we show multiple lists which is cumbersome with space. A submenu solves that nicely imo, especially for the hidden network item. I still think we should prioritize previously connected networks in the list, but I think a submenu solves enough issues that we don't really have to worry anymore about showing the full list. I agree mostly that you only really connect to a new wireless network when you're somewhere you've never been before which is probably not super often and it would be okay to just kick you to settings for that

I suppose there wouldn't be any difference to most people between just not opening the context menu vs removing the AP list. It's there if you want it, but mostly it's hidden 🤷🏻‍♀️

[leonardo-lemos]

I like the solution, it works as expected and code looks good. Approved.

[stsdc]

To be clear, I'm not against submenus, per se. Just sharing an opinion that it looks a bit odd to me (it gave gnome2/xfce vibes).
Maybe later we could do this in the way we did with the account/avatar icon in Quick Settings 🤔 ?

Also, should we add an updated screenshot for readme? Since the UI change.

[leolost2605]

I think we should definitely keep the AP list (maybe even with all APs). I use eOS on my laptop and I regularly have to connect to different and new wifi networks. E.g. Home, University, Cafe, a new Cafe we want to try, Train, library, public space.
Also e.g. in the university we have two wifi networks where in some areas one works better than the other so I have to switch between them. Also one allows to connect to the intranet the other doesn't.

Regarding the proposed solution here I'm not sure it's intuitive and even less discoverable. Nowhere else we use "menu on button" (or do we?). The only case we use it is when it's the primary function i.e. menu button. Also on mobile you can't open settings via the indicator then (or did I miss something?).
One thing that's also not very intuitive but used by Android and more importantly makes it at least discoverable is popping up the menu as the primary click and having a switch in the popover which IMHO would be better.

[danirabbit]

@stsdc I don't totally love the design of the stack switcher submenu, but I'm not totally opposed to it either. In GTK4 we have a lot more freedom with positioning popovers and styling them etc. So I think I want to try some alternatives there.

@leolost2605 ah yeah in iOS having further options on long-press for quick controls is pretty standard so I probably carried my assumptions over here. I guess one thing else they do is that there's a disclosure triangle next to the description text and that's also tappable, so you're probably right this needs some kind of further affordances.

Gonna convert back to draft since there was some valid criticisms raised! Thank you for all of your input :)

[TomiOhl]

The radical solution would be to just remove AP list completely from the popover. Instead open WiFi settings. Because how often do we switch WiFis on PC?

Maybe not on PC, but on laptops definitely. I have to switch to a different wifi every day, since there is an ap that's preferred mostly for some reason and the laptop will try to connect to that at any cost, even though it's barely reachable in my kitchen - then I have to switch manually.

I guess one thing else they do is that there's a disclosure triangle next to the description text and that's also tappable, so you're probably right this needs some kind of further affordances.

Exactly that's what I miss! At least some visual/clickable clue would be useful. On the other hand, showing the list right away is even more comfortable from my perspective

[stsdc]

Windows 11 approach. I see a Quick Settings pattern here.

[stsdc]

This new Android Quick Settings solves some issues: https://youtu.be/j7W2v_FmCuE?si=v4pqBBApxd3msAy0&t=534