-
-
Notifications
You must be signed in to change notification settings - Fork 0
Update README.md: Add release guide #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request introduces a new section titled "How to release a new version?" in the Changes
Possibly related PRs
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
42-44
: Convert Bare URL to Markdown LinkLine 44 contains a bare URL (
https://github.com/elimu-ai/common-utils/releases
), which violates Markdown style guidelines (MD034). Converting this URL into a Markdown-formatted link will improve readability and maintain consistency with best practices. Consider the following diff:-3. Draft a new Release in https://github.com/elimu-ai/common-utils/releases +3. Draft a new Release in [GitHub Releases](https://github.com/elimu-ai/common-utils/releases)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
44-44: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
44-44: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build (windows-latest, 21)
- GitHub Check: build (windows-latest, 17)
🔇 Additional comments (1)
README.md (1)
40-41
: New Release Guide Section AddedThe new section "How to release a new version?" is clear and concise, providing a straightforward step-by-step guide for the release process. This addition aligns well with the PR objectives.
@jo-elimu Can you please confirm if the release steps here are exactly the same as what you often do to release other apps/libraries? |
@tuancoltech If you were to do all the release steps manually, it would look something like this:
|
@jo-elimu As per in https://github.com/elimu-ai/content-provider/blob/main/app/build.gradle, the work of adding Anything you could think of as the reason for which |
@tuancoltech You mean this error here?: https://github.com/elimu-ai/common-utils/actions/runs/13941674979/job/39019598597 If you try to tag the same version number twice, that will cause an error. Could that be the reason? For example, if ![]() |
@jo-elimu No. The error I was referring to is related to ![]() Even though there was no exception log, it seems push wasn't successful because I could not see the I was wondering if that's because I use my git user info when running those tasks. Reference: https://github.com/elimu-ai/common-utils/actions/runs/13941708067/job/39019703815 |
@tuancoltech This might have to do with a missing GitHub token. The account |
Thanks. I'll try in next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
42-44
: Step Instructions Clarity & Link Formatting Improvement
The bullet list provides a concise, step-by-step guide for the release process. However, note that step 3 uses a bare URL, which triggers a markdownlint warning (MD034). Consider converting it to a Markdown link (e.g.,[GitHub Releases](https://github.com/elimu-ai/common-utils/releases)
) for better readability and to adhere to markdown standards.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
44-44: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
44-44: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build (windows-latest, 21)
- GitHub Check: build (windows-latest, 17)
🔇 Additional comments (1)
README.md (1)
40-41
: Release Guide Section Heading is Clear
The new section heading “## How to release a new version?” is clearly defined and easy to locate in the README. This makes it straightforward for users to find the release instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
40-44
: New Release Guide Section: Improve URL Formatting & Clarify SNAPSHOT NoteThe added "How to release a new version?" section clearly outlines the steps for releasing a new version. However, please consider the following improvements:
- Bare URL in Step 3: In line 44, a bare URL is used. Markdown best practices suggest using a markdown-formatted link to improve readability and avoid markdownlint warnings (MD034). For example, replace
withDraft a new Release in https://github.com/elimu-ai/common-utils/releases
Draft a new Release in [GitHub Releases](https://github.com/elimu-ai/common-utils/releases)
- Clarify the
-SNAPSHOT
Suffix Note: The instruction in step 1 advises not to remove theSNAPSHOT
suffix, which might seem confusing given that in some projects the suffix is managed automatically (as noted in previous discussions). It would be beneficial to clarify if the suffix is auto-appended by the release task or if manual intervention is required.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
44-44: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
44-44: Bare URL used
null
(MD034, no-bare-urls)
Co-authored-by: Jo G. <1451036+jo-elimu@users.noreply.github.com>
f21c421
to
7fe0b72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
44-44
: Fix Bare URL Markdown WarningThe URL in step 3 is currently a bare URL, which triggers a markdown lint warning (MD034). Consider converting it to a proper markdown link. For example:
-3. Draft a new Release in https://github.com/elimu-ai/common-utils/releases +3. Draft a new Release in [this link](https://github.com/elimu-ai/common-utils/releases)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
44-44: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
44-44: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build (windows-latest, 17)
- GitHub Check: build (windows-latest, 21)
🔇 Additional comments (1)
README.md (1)
40-45
: Well-Structured Release Guide AdditionThe new "How to release a new version?" section clearly outlines the required steps for releasing a new version. It provides a logical sequence: updating build configurations, triggering the release workflow, and drafting a new release. Please ensure that these steps remain synchronized with any automation in our CI/CD pipeline to avoid discrepancies.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
44-44: Bare URL used
null(MD034, no-bare-urls)
Update README.md: Add release guide
Summary by CodeRabbit