remove unused dependencies #65

jo-elimu · 2025-04-30T17:57:25Z

The common-utils library should not depend on any other elimu.ai library. See library dependency flowchart here: https://github.com/elimu-ai/wiki/blob/main/SOFTWARE_ARCHITECTURE.md#library-dependencies

Issue Number

Resolves Remove unused dependencies #64

Purpose

Technical Details

Testing Instructions

Regression Tests

Screenshots

Summary by CodeRabbit

Chores
- Removed unused configuration entries and dependencies related to content provider functionality.
- Cleaned up project files by deleting obsolete permission declarations and version references.
- Removed outdated documentation comments from code.
- Updated README with an additional repository reference for version management.

#64

coderabbitai · 2025-04-30T17:59:04Z

Walkthrough

This pull request removes all references to the elimu-content-provider dependency and its associated configuration from the project. Specifically, it deletes the dependency from Gradle files, eliminates related version declarations, removes manifest placeholders and build config fields, and deletes a permission entry from the AndroidManifest. Additionally, a multi-line comment about TTS language provider implementation is removed from a Kotlin file. No functional or public API changes are introduced. These updates align with the goal of streamlining dependency management in line with elimu.ai's mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

Changes

File(s)	Change Summary
app/build.gradle, utils/build.gradle, gradle/libs.versions.toml	Removed `elimu-content-provider` dependency, its version, and related build configuration.
app/src/main/AndroidManifest.xml	Removed permission entry referencing `${contentProviderApplicationId}`.
utils/src/main/java/ai/elimu/common/utils/viewmodel/TextToSpeechViewModelImpl.kt	Deleted a multi-line explanatory comment about TTS language provider implementation.
README.md	Added `appstore` repository to the list where `utils` version must be bumped after release.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Remove unused dependencies (#64)	✅

Possibly related PRs

Allow passing custom language to TextToSpeech's initialization #10: This PR originally added the manifest placeholder, build config field, and content provider dependency that are now being removed.
Remove the APIs for providing custom TTS language selection #42: This PR removed APIs and implementation related to custom TTS language selection and the content provider, closely related to the removals in this PR.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

#64

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

README.md (1)
58-58: Refactor: Replace bare URL with descriptive markdown link
markdownlint flags a bare URL here (MD034). For better readability and to comply with lint rules, replace the raw link with a labeled markdown link. For example:
* [appstore libs.versions.toml](https://github.com/elimu-ai/appstore/blob/main/gradle/libs.versions.toml)
This small tweak ensures our docs stay clean and accessible, supporting elimu.ai’s mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

58-58: Bare URL used
null

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35f6ab2 and 338ab52.

📒 Files selected for processing (3)

README.md (1 hunks)
gradle/libs.versions.toml (0 hunks)
utils/build.gradle (0 hunks)

💤 Files with no reviewable changes (2)

utils/build.gradle
gradle/libs.versions.toml

🧰 Additional context used

🪛 markdownlint-cli2 (0.17.2)

README.md

58-58: Bare URL used
null

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: build (windows-latest, 21)
GitHub Check: build (windows-latest, 17)
GitHub Check: build (macos-latest, 17)
GitHub Check: build (ubuntu-latest, 17)
GitHub Check: build (macos-latest, 21)
GitHub Check: build (ubuntu-latest, 21)
GitHub Check: lint

tuancoltech

Please resolve merge conflicts.

jo-elimu · 2025-05-02T08:03:49Z

Please resolve merge conflicts.

@tuancoltech Resolved ☑️

jo-elimu added 2 commits May 1, 2025 00:49

refactor: remove content-provider lib

4f7b3fc

#64

refactor: remove references to content-provider lib

35f6ab2

#64

jo-elimu self-assigned this Apr 30, 2025

jo-elimu requested a review from a team as a code owner April 30, 2025 17:57

jo-elimu linked an issue Apr 30, 2025 that may be closed by this pull request

Remove unused dependencies #64

Closed

jo-elimu requested a review from tuancoltech April 30, 2025 17:57

coderabbitai bot approved these changes Apr 30, 2025

View reviewed changes

refactor: remove model lib

338ab52

#64

coderabbitai bot reviewed Apr 30, 2025

View reviewed changes

tuancoltech requested changes May 2, 2025

View reviewed changes

Merge branch 'main' into 64-remove-unused-dependencies

f931679

tuancoltech approved these changes May 2, 2025

View reviewed changes

jo-elimu merged commit cad1df8 into main May 3, 2025
7 checks passed

jo-elimu deleted the 64-remove-unused-dependencies branch May 3, 2025 03:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

remove unused dependencies #65

remove unused dependencies #65

Uh oh!

jo-elimu commented Apr 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

tuancoltech left a comment

Uh oh!

jo-elimu commented May 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

remove unused dependencies #65

remove unused dependencies #65

Uh oh!

Conversation

jo-elimu commented Apr 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Number

Purpose

Technical Details

Testing Instructions

Regression Tests

Screenshots

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

tuancoltech left a comment

Choose a reason for hiding this comment

Uh oh!

jo-elimu commented May 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jo-elimu commented Apr 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)