feat: Sharding implementation #1648
Open
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d defn files. only the Mesh module has a standalone file now
polvalente
reviewed
Dec 17, 2025
nx/lib/nx/defn/shard/mesh.ex
Outdated
Comment on lines
1
to
2
| defmodule Nx.Defn.Shard.Mesh do | ||
| defstruct [:name, :shape] |
Contributor
There was a problem hiding this comment.
We should have a moduledoc that explains what exactly shape is and why does the mesh have a name
polvalente
reviewed
Dec 17, 2025
nx/lib/nx/defn/compiler.ex
Outdated
| @doc """ | ||
| Callback for compilation. | ||
| Its main purpose is to compile a function for a given mesh. |
Contributor
There was a problem hiding this comment.
Suggested change
| Its main purpose is to compile a function for a given mesh. | |
| Its main purpose is to compile a function for a given `Nx.Defn.Shard.Mesh`. |
If possible, can we also expand on why the third argument is [vars] instead of vars?
Contributor
Author
There was a problem hiding this comment.
Updated the documentation. I also included your suggested changes manually
polvalente
reviewed
Dec 17, 2025
nx/lib/nx/defn/compiler.ex
Outdated
| @callback __to_backend__(keyword) :: {module, keyword} | ||
|
|
||
| @doc """ | ||
| Callback for compilation. |
Contributor
There was a problem hiding this comment.
Suggested change
| Callback for compilation. | |
| Callback for compilation of a parallelizable computation. |
josevalim
reviewed
Dec 19, 2025
| @@ -0,0 +1,16 @@ | |||
| defmodule Nx.Defn.Shard.Mesh do | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| defmodule Nx.Defn.Shard.Mesh do | |
| defmodule Nx.Defn.Mesh do |
Let's avoid too deep nesting. So either Nx.Defn.Mesh or, if we feel it will be used outside of defn, Nx.Mesh.
josevalim
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of sharding support on Nx. Related to issue #645 pmap support