Skip to content

fixed string index out of range exception #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed string index out of range exception #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion precise_bbcode/bbcode/defaults/tag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class Options:

def render(self, value, option=None, parent=None):
href = option if option else value
if href[0] == href[-1] and href[0] in ('"', '\'') and len(href) > 2:
if len(href) > 2 and href[0] == href[-1] and href[0] in ('"', '\''):
# URLs can be encapsulated in quotes (either single or double) that aren't part of the
# URL. If that's the case, strip them out.
href = href[1:-1]
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ class TestParser(object):
('[color=some words]test[/color]', '[color=some words]test[/color]'),
# Unknown BBCodes
('[unknown][hello][/unknown]', '[unknown][hello][/unknown]'),
('[url]"[url]', '[url]"[url]'),
('[url="]wow, that is very short[url]', '[url="]wow, that is very short[url]'),
)

CUSTOM_TAGS_RENDERING_TESTS = {
Expand Down