Skip to content

A hacky 'fix' for the scrolling bug - better'n'nothin'? #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A hacky 'fix' for the scrolling bug - better'n'nothin'? #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions elm_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@
import sublime, sublime_plugin


class ElmRescrollCommand(sublime_plugin.TextCommand):
def run(self, edit, x, y):
self.view.set_viewport_position((x, y), False)


class ElmFormatCommand(sublime_plugin.TextCommand):
def run(self, edit):
prev_viewport_position = self.view.viewport_position()

# Hide the console window on Windows
shell = False
Expand All @@ -23,13 +29,15 @@ def run(self, edit):
old_path = os.environ['PATH']
os.environ['PATH'] = os.path.expandvars(path + path_separator + '$PATH')

command = [binary, self.view.file_name(), '--yes']
command = [binary, self.view.file_name(), '--yes', '--elm-version=0.19']
p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=shell)

if path:
os.environ['PATH'] = old_path

output, errors = p.communicate()
rescroll = lambda: self.view.run_command('elm_rescroll', { "x": prev_viewport_position[0], "y": prev_viewport_position[1] })
sublime.set_timeout(rescroll, 700)

if errors.strip():
# If there is a error while running it. It should show the syntax errors
Expand All @@ -38,7 +46,7 @@ def run(self, edit):
panel_view.run_command('erase_view')

# elm-format should have a --no-color option https://github.com/avh4/elm-format/issues/372
errors = re.sub('\x1b\[\d{1,2}m', '', errors.strip().decode())
errors = re.sub('\x1b\\[\\d{1,2}m', '', errors.strip().decode())

panel_view.run_command('append', {'characters': errors})
panel_view.set_read_only(True)
Expand Down