-
-
Notifications
You must be signed in to change notification settings - Fork 361
Add lifecycle hooks and setImmediate polyfill for cf workers #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Vicentesan
wants to merge
7
commits into
elysiajs:main
Choose a base branch
from
Vicentesan:vicentesan/cloudflare-worker-lifecycle-hooks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aca3934
feat(cloudflare): add lifecycle hooks and setimmediate polyfill for w…
Vicentesan 91b6246
chore: remove uncessary test file
Vicentesan cdd9b10
wip: fix some pr comments
Vicentesan 4f33c60
wip(cloudflare): improve execution context handling for workers
Vicentesan 69292bd
fix(cloudflare-worker): improve error handling in stop hooks and fetc…
Vicentesan 8fe655d
chore
Vicentesan 2db8cb7
wip(cloudflare): improve execution context handling and memory manage…
Vicentesan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep ExecutionContext alive until the request truly finishes
We set
globalThis.__cloudflareExecutionContext = ctx
, calloriginalFetch(request)
, and then immediately clear the global before the returned promise settles. All downstream async work (handlers,finally
blocks,afterResponse
, etc.) therefore run with the context wiped out, sowaitUntil
is never available and the feature still falls back to the Promise branch. The same happens on errors—cleanup runs before hooks fire.Wrap the
originalFetch
call so the context remains set for the entire lifetime of the request and only restore/clear it in afinally
after the promise resolves, e.g.:This keeps
waitUntil
reachable forafterResponse
while still preventing leaks and restores any prior context to avoid cross-request bleeding.📝 Committable suggestion
🤖 Prompt for AI Agents