Fix: Properly clean up track-mouse when mouse tracking is disabled #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lsp-ui-doc-show-with-mouse is nil or when lsp-ui-doc-mode is disabled, track-mouse was not being cleared. This caused mouse movements to generate command events that would: - Hide the lsp-ui-doc popup unexpectedly (even when shown via glance) - Interrupt isearch causing it to exit Fixes: 1. Clear track-mouse in lsp-ui-doc--setup-mouse when disabled 2. Remove redundant track-mouse management from lsp-ui-doc--make-request 3. Clean up track-mouse when mode is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
lsp-ui-doc-show-with-mouseis nil or whenlsp-ui-doc-modeis disabled, track-mouse was not being cleared. This caused mouse movements to generate command events that would:Fixes #795 :
track-mouseinlsp-ui-doc--setup-mousewhen disabledtrack-mousemanagement fromlsp-ui-doc--make-requesttrack-mousewhen mode is disabled