Skip to content

feat: init v2 #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: init v2 #606

wants to merge 2 commits into from

Conversation

aklkv
Copy link

@aklkv aklkv commented Jun 7, 2025

it's massive but it works

publishing most likely broken at the moment

[side-note]: we need to audit some parts like

  • dummy app, I have migrated it in the new format but do we need it and all it styles
  • part in index.js
  • node-tests

@aklkv aklkv force-pushed the feat/v2 branch 2 times, most recently from ec6856c to 37d804d Compare June 7, 2025 10:30
@aklkv
Copy link
Author

aklkv commented Jun 20, 2025

@MelSumner I think it's ready for review except it were are some new a11y failed tests, I am guessing I bumped axe-code by accident and questions in description

@MelSumner
Copy link
Member

I don't think we need the dummy app anymore TBQH.

@aklkv
Copy link
Author

aklkv commented Jun 20, 2025

I don't think we need the dummy app anymore TBQH.

should we drop related to dummy app then?

@NullVoxPopuli
Copy link

should we drop related to dummy app then?

ya

@NullVoxPopuli
Copy link

I think it'd be good to have a demo vite app in here (which would mean monorepoing this repo) -- could also exist in a separate repo on this org, but there'd be DX issues to work out with compilation and all that (if no compilation, folks could just use git refs)

@aklkv
Copy link
Author

aklkv commented Jul 16, 2025

I think it'd be good to have a demo vite app in here (which would mean monorepoing this repo) -- could also exist in a separate repo on this org, but there'd be DX issues to work out with compilation and all that (if no compilation, folks could just use git refs)

I can add demo vite app in repo, was hoping to avoid it but oh well seems it's the way to have more stability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants