-
-
Notifications
You must be signed in to change notification settings - Fork 405
Propose moving blueprints off of the release train #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| However, default blueprints (what `ember new` / `ember addon` generate) have different ergonomics than framework runtime code: | ||
|
|
||
| - Blueprint changes primarily affect *newly generated* projects, not existing ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this highly questionable as ember-cli-update will run ember new as part of an upgrade of an existing project
I don't want that to suddenly be the latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ember-cli-update runs on ember-cli's output, not the direct output of a blueprint, so this workflow is unchanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct me if I'm wrong but it 100% does ember new under the hood for you, which this rfc proposes changes what it would do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change is that IF we need to update old versions, we would need to update ember-cli, and then there is no issue with ecu
| However, default blueprints (what `ember new` / `ember addon` generate) have different ergonomics than framework runtime code: | ||
|
|
||
| - Blueprint changes primarily affect *newly generated* projects, not existing ones. | ||
| - The common social workflow is to propose blueprint improvements via PRs to the default branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this suggests to me that you cannot fix/patch previous bp version, what happens when the bp tries to use a nodejs feature that doesn't exist on all supported version of the bp it's trying to generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we release a new ember-cli with the fix in the rare case where that would happen
|
|
||
| Additionally, while blueprints have historically been used as part of Ember’s upgrade and migration story, that can have an unintended cost for *new* users: improvements that primarily exist to support long-lived apps and slower-moving upgrade paths can accumulate in the defaults. This can leave new users feeling like they are “paying” for technical debt created by projects that cannot keep up, and that the defaults are holding them back. | ||
|
|
||
| We can also think of official blueprints as a *product*: they are the first experience many users have with Ember, and they encode decisions about tooling, project layout, and “pit of success” defaults. Like any product, we want customers to receive fixes and refinements as quickly as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not at the cost of stability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not a cost -- not something we're trading away with this proposal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's too big of a tradeaway for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just saying we don't give up any stability
|
|
||
| Each `ember-cli` release must pin to an *exact* blueprint version for each blueprint package it uses. | ||
|
|
||
| In practice, this means the `ember-cli` `package.json` uses exact versions (e.g. `"1.2.3"`, not `"^1.2.3"` or `"~1.2.3"`) for blueprint dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes things worse by cutting off ability for us to release fixes for ember-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all we have to do is release ember-cli for the fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but nobody will see them since they are pinned to exact version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they aren't updating ember-cli, why would they update their blueprint?
ember-cli is already nearly pinned, as it uses ~ on the blueprint versions
|
|
||
| - Blueprint changes primarily affect *newly generated* projects, not existing ones. | ||
| - The common social workflow is to propose blueprint improvements via PRs to the default branch. | ||
| - When blueprint improvements are tied to a release train, users can wait weeks (or longer) to see improvements in newly generated apps and addons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general feeling already is that things are moving too fast in the js ecosystem and nobody is able to keep up, waiting ~6 weeks is not a bad thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think anything is moving too fast in our ecosystem.
| When a user runs `ember new` or `ember addon`, `ember-cli` must: | ||
|
|
||
| 1. Determine the bundled blueprint version (from its pinned dependency). | ||
| 2. Check the registry for the latest blueprint version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are plenty of restricted systems that don't allow network access or would rely on internal mirrors that have been vetted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine -- they wouldn't be prompted
Propose moving blueprints off of the release train
Rendered
Summary
This pull request is proposing a new RFC.
To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.
A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.
An FCP is required before merging this PR to advance to Accepted.
Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.
Exploring Stage Description
This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.
An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an
Exploringlabel applied.An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.
Accepted Stage Description
To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.
If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.
When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.
Checklist to move to Exploring
S-Proposedis removed from the PR and the labelS-Exploringis added.Checklist to move to Accepted
Final Comment Periodlabel has been added to start the FCP