Fixes in OOP notebook #340
Conversation
for more information, see https://pre-commit.ci
edoardob90
left a comment
edoardob90
left a comment
There was a problem hiding this comment.
My only comment is on a type hint 😉
Co-authored-by: Edoardo Baldi <edoardo.baldi@empa.ch>
Snowwpanda
left a comment
Snowwpanda
left a comment
There was a problem hiding this comment.
Nice work @despadam.
I dont have much to say also since the PR was mostly text editing and formulation.
I found a mistake in the validation of the exercise oop_compare_persons. It might be a bit short notice to fix though. Let me know if you want input from me.
| " # Write your solution here\n", | ||
| " return" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
I know no changes were made to the exercises, but i had a look at compare_persons, this exercise test doesn't actually work. because you create the class Person multiple times it is actually overwritten in the same context. The comparison always returns false because "isinstance(..)" is false
i think a fix might be a bit more complicated...
Co-authored-by: Pascal Su <pascal.su@empa.ch>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Snowwpanda
left a comment
Snowwpanda
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix!
Co-authored-by: Pascal Su <pascal.su@empa.ch>
for more information, see https://pre-commit.ci
This PR does not make changes in the exercises, only makes some parts of the text clearer.