Remove LINKABLE from COMPILE_TIME_SETTINGS. NFC #25674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe one day in the part in needed to be here becuase SIDE_MODULE and MAIN_MODULE are both compile-time settings (since they imply PIC). But the automatic setting of LINKABLE, based on MAIN_MODULE now happens only in link.py.
kripken
approved these changes
Oct 28, 2025
|
Hm... we can't do this actually since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe one day in the past it needed to be here becuase SIDE_MODULE and MAIN_MODULE are both compile-time settings (since they imply PIC). But the automatic setting of LINKABLE, based on MAIN_MODULE now happens only in link.py.