Fix bulk memory feature removal in optimizing builds #25719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #25718 |
juj
reviewed
Nov 5, 2025
juj
reviewed
Nov 5, 2025
sbc100
force-pushed
the
data_count
branch
4 times, most recently
from
f285fef to
2dd506a
Compare
|
Rebased |
juj
reviewed
Nov 5, 2025
juj
reviewed
Nov 5, 2025
| self.emcc('hello_world.c', ['-O3', '-o', 'bulk.js']) | ||
| self.assertTrue(has_data_count('bulk.wasm')) | ||
|
|
||
| self.emcc('hello_world.c', ['-O3', '-o', 'nobulk.js', '-mno-bulk-memory', '-mno-bulk-memory-opt']) |
There was a problem hiding this comment.
I wonder if it might make sense to test the '-mno-bulk-memory' and '-mno-bulk-memory-opt' separately?
IIUC '-mno-bulk-memory' implies '-mno-bulk-memory-opt'?
So self.emcc('hello_world.c', ['-O3', '-o', 'nobulk.js', '-mno-bulk-memory'] should not get bulk memory either?
There was a problem hiding this comment.
IIUC
'-mno-bulk-memory'implies'-mno-bulk-memory-opt'?
From the LLVM POV, I'm not sure it does sadly.
juj
approved these changes
Nov 5, 2025
The bug here was the `binaryen_features` was been stashed right away after linking and then used unmodified for future binaryen calls. Fixes: emscripten-core#25479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug here was the BINARYEN_FEATURES was been stashed right away after linking and then used unmodified for future binaryen calls.
Fixes: #25479