Move BINARYEN_PASSES out of settings_internal.js. NFC #25720
Merged
+13
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
BINARYEN_PASSES
branch
from
413048c to
5013fb7
Compare
kripken
approved these changes
Nov 5, 2025
sbc100
force-pushed
the
BINARYEN_PASSES
branch
from
5013fb7 to
11ac339
Compare
I'm making an effort to remove stuff from `settings_internal.js` unless its specifically needed by the JS compiler. We might want to invent a new place for such python global state but we I think we can add this organically, over time.
sbc100
force-pushed
the
BINARYEN_PASSES
branch
from
11ac339 to
c02781e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making an effort to remove stuff from
settings_internal.jsunless its specifically needed by the JS compiler.We might want to invent a new place for such python global state but we I think we can add this organically, over time.
See #25721