- 
                Notifications
    
You must be signed in to change notification settings  - Fork 35
 
WRQ-11247: Added fontScale prop for large text mode scale values #3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            mmyelyn
  wants to merge
  12
  commits into
  develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
feature/large-text
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Draft
                    Changes from 5 commits
      Commits
    
    
            Show all changes
          
          
            12 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      059009a
              
                Implemented to update base font size when fontScale changes
              
              
                mmyelyn 60cd8d6
              
                Revert Api that was unnecessarily changed to public to private
              
              
                mmyelyn 7edf27d
              
                Specified fontScale default value in calculateFontSize
              
              
                mmyelyn dc800af
              
                Fixed lint warning
              
              
                mmyelyn 0166ae2
              
                Applied reviews
              
              
                mmyelyn a371997
              
                Applied reviews
              
              
                mmyelyn 4b93d18
              
                Modified the fontScale value to be managed by resolution internal var…
              
              
                mmyelyn a1b27c3
              
                Applied review
              
              
                mmyelyn 09fe9d2
              
                Merge branch 'develop' into feature/large-text
              
              
                mmyelyn 7efab79
              
                Modified so that fontScale can be applied when adjusting the scale value
              
              
                mmyelyn 5308615
              
                Added fontScale to config of ResolutionDecorator
              
              
                mmyelyn 7d442c5
              
                Merge branch 'develop' into feature/large-text
              
              
                mmyelyn File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.