-
Notifications
You must be signed in to change notification settings - Fork 6
WRQ-8004: Focus on Body Text partially in Scroller with audio guidance ON #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1556 +/- ##
========================================
Coverage 81.24% 81.24%
========================================
Files 141 141
Lines 6499 6499
Branches 1921 1921
========================================
Hits 5280 5280
Misses 932 932
Partials 287 287 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
…sample Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Let's move the ScrollWithBodyTextFocus to Scroller by adding one more Toggle Button which enables and disables audioGuidance. To not affect original Scroller qa-a11y samples, ScrollView will return the original div with Foo, Bar when audioGuidance is |
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix travis fails and assign back to me
|
||
const handleChangeJSNativeButton = () => setNative(!native); | ||
const handleChangeAriaLabelButton = () => setCustomAriaLabel(!customAriaLabel); | ||
const handleChangeAudioGuidance = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function breaks my previous qa-a11y test cases.
- Turn on audio guidance from the settings app
- run qa-a11y app
- select Scroller menu
- Test the focused scrollbar
- switch on the Audio Guidance
- Test the new Scroller you added (non-focusable scrollbar)
- switch off the Audio Guidance
- How can I check the original test number 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed audio guidance call from the sample code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated code looks OK.
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
LGTM but this requirement is dropped as of now. I won't close this PR in case the requirement will be live later. |
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Checklist
Issue Resolved / Feature Added
For accessibility, we need a scroller sample that changes its behavior depending on the value of audio guidance.
Using spottable, focus can be moved in the body text area by up/down key and scroll moves following focus.
Resolution
Changed the scroller sample in qa-a11y to partially focus on body text when audio guidance is on.
Additional Considerations
Links
WRQ-8004
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)