Skip to content

Conversation

vJIYEv
Copy link
Contributor

@vJIYEv vJIYEv commented Feb 6, 2024

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

For accessibility, we need a scroller sample that changes its behavior depending on the value of audio guidance.

  • When audio guidance is off, scroll thumb or whole body text should be focused and the focus can be moved between them by Enter key.
  • When audio guidance is on, body text should be splited into several parts and each part should get focus as a spottable element.
    Using spottable, focus can be moved in the body text area by up/down key and scroll moves following focus.

Resolution

Changed the scroller sample in qa-a11y to partially focus on body text when audio guidance is on.

  • get the value of audio guidance from settings
  • focusableScrollbar option is true/'byEnter' when audio guidance is on/off.
  • apply/not apply spottable to each part of body text when auido guidance is on/off.

Additional Considerations

Links

WRQ-8004

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b2a3c6) 81.24% compared to head (5f74380) 81.24%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1556   +/-   ##
========================================
  Coverage    81.24%   81.24%           
========================================
  Files          141      141           
  Lines         6499     6499           
  Branches      1921     1921           
========================================
  Hits          5280     5280           
  Misses         932      932           
  Partials       287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vJIYEv vJIYEv changed the title WRQ-8044: Focus on Body Text partially in Scroller with audio guidance ON WRQ-8004: Focus on Body Text partially in Scroller with audio guidance ON Feb 6, 2024
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
…sample

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
@juwonjeong
Copy link
Contributor

juwonjeong commented Feb 15, 2024

Let's move the ScrollWithBodyTextFocus to Scroller by adding one more Toggle Button which enables and disables audioGuidance.

To not affect original Scroller qa-a11y samples, ScrollView will return the original div with Foo, Bar when audioGuidance is off. And returns that wrapped Spottable divs when audioGuidance is `on.

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link
Contributor

@juwonjeong juwonjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@seunghoh seunghoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix travis fails and assign back to me


const handleChangeJSNativeButton = () => setNative(!native);
const handleChangeAriaLabelButton = () => setCustomAriaLabel(!customAriaLabel);
const handleChangeAudioGuidance = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function breaks my previous qa-a11y test cases.

  1. Turn on audio guidance from the settings app
  2. run qa-a11y app
  3. select Scroller menu
  4. Test the focused scrollbar
  5. switch on the Audio Guidance
  6. Test the new Scroller you added (non-focusable scrollbar)
  7. switch off the Audio Guidance
  8. How can I check the original test number 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed audio guidance call from the sample code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated code looks OK.

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
@seunghoh seunghoh marked this pull request as draft February 29, 2024 01:34
@seunghoh
Copy link
Member

LGTM but this requirement is dropped as of now. I won't close this PR in case the requirement will be live later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants